Closed
Conversation
7 tasks
16 tasks
Maleware
reviewed
Mar 31, 2023
Member
There was a problem hiding this comment.
there is a slash too much in https://github.com/stackabletech//operator-rs.git
Member
There was a problem hiding this comment.
I remember from the back of my head that it's intentional and needed. You can try to remove it and see how it goes
Member
There was a problem hiding this comment.
Works with both for me :) But I changed the other tomls too.
Member
Author
There was a problem hiding this comment.
Hm when I removed the // cargo complained that I have the same origin multiple times (which was true). It only worked with // (in the patch section)
bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
# Description [CI](https://ci.stackable.tech/job/hbase-operator-it-custom/79/) failed but the failed tests work locally (on kind). *Please add a description here. This will become the commit message of the merge request later.* Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI failed but the failed tests work locally (on kind).
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information