Skip to content

Remove sed calls to replace KERBEROS_REALM as they are not needed any more when HBase is built against Hadoop 3#531

Merged
soenkeliebau merged 15 commits intomainfrom
fix/#505
Jul 19, 2024
Merged

Remove sed calls to replace KERBEROS_REALM as they are not needed any more when HBase is built against Hadoop 3#531
soenkeliebau merged 15 commits intomainfrom
fix/#505

Conversation

@soenkeliebau
Copy link
Copy Markdown
Member

@soenkeliebau soenkeliebau commented Jul 17, 2024

Description

In the past we built HBase against Hadoop 2.x, in which the Configuration object did not yet support the syntax for using environment variables in config files: ${env.VARNAME}

To work around this we added sed calls to do the replacement in the config files during container startup.

Since we now build HBase with Hadoop 3.x this functionality is now supported by HBase and we don't need these calls to sed anymore, as the placeholders will be replaced by HBase at runtime.

This PR removes the now unneeded calls.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [x] Changelog updated
# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

Since the syntax differs between what hdfs expects and what config-utils uses, this only works together with the sister PR in hdfs-operator from branch `fix/config-util-compatible-discovery`.
@soenkeliebau soenkeliebau marked this pull request as draft July 17, 2024 17:35
Since we build HBase with Hadoop 3 these days, the functionality to use environment variables in config files is now available natively and we do not need to rely on sed anymore.
@soenkeliebau soenkeliebau requested a review from sbernauer July 18, 2024 15:34
@soenkeliebau soenkeliebau marked this pull request as ready for review July 18, 2024 15:34
@soenkeliebau soenkeliebau changed the title Replace sed calls with config-utils Remove sed calls to replace KERBEROS_REALM as they are not needed any more when HBase is built against Hadoop 3 Jul 19, 2024
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
New attempt without the IDE "fixing" a lot of stuff all throughout the markdown file..
@soenkeliebau soenkeliebau requested a review from lfrancke July 19, 2024 10:38
@soenkeliebau soenkeliebau added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 0cc9e91 Jul 19, 2024
@soenkeliebau soenkeliebau deleted the fix/#505 branch July 19, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants