Skip to content

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Jan 23, 2023

Description

  • Split up usage into multiple pages
  • deleted implementation.adoc
    • some content was moved to the index.adoc
  • fixed a link that used md syntax
  • removed a nightly reference that was marked with TODO
  • added more cross-links so readers find things easier

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@fhennig fhennig marked this pull request as ready for review January 23, 2023 11:15
@maltesander maltesander self-requested a review January 23, 2023 12:47
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things..

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Jan 24, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jan 24, 2023
# Description

- Split up usage into multiple pages
- deleted implementation.adoc
  - some content was moved to the index.adoc
- fixed a link that used md syntax
- removed a nightly reference that was marked with TODO
- added more cross-links so readers find things easier



Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title docs: reorganized usage guide and 'implementation.adoc' [Merged by Bors] - docs: reorganized usage guide and 'implementation.adoc' Jan 24, 2023
@bors bors bot closed this Jan 24, 2023
@bors bors bot deleted the docs/minor-restructuring branch January 24, 2023 07:54
fhennig added a commit that referenced this pull request Jan 26, 2023
- Split up usage into multiple pages
- deleted implementation.adoc
  - some content was moved to the index.adoc
- fixed a link that used md syntax
- removed a nightly reference that was marked with TODO
- added more cross-links so readers find things easier

Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
fhennig added a commit that referenced this pull request Jan 26, 2023
- Split up usage into multiple pages
- deleted implementation.adoc
  - some content was moved to the index.adoc
- fixed a link that used md syntax
- removed a nightly reference that was marked with TODO
- added more cross-links so readers find things easier

Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants