Skip to content

Productionize HDFS rego rules #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 15 commits into from
Mar 26, 2024
Merged

Productionize HDFS rego rules #11

sbernauer merged 15 commits into from
Mar 26, 2024

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 14, 2024 •
edited by siegfriedweber
Loading

Description

Part of stackabletech/issues#523
This PR adds support for regex to match userNames, shortUsernames and groups to the rego rules.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added

# Acceptance
- [ ] Proper release label has been added

@sbernauer sbernauer changed the title "Productionize" rego rules "Productionize" HDFS rego rules Mar 14, 2024
@sbernauer sbernauer changed the title "Productionize" HDFS rego rules Productionize HDFS rego rules Mar 14, 2024
@sbernauer sbernauer marked this pull request as ready for review March 14, 2024 11:31
@sbernauer sbernauer self-assigned this Mar 18, 2024
@sbernauer sbernauer mentioned this pull request Mar 18, 2024
Closed
siegfriedweber
siegfriedweber requested changes Mar 20, 2024
View reviewed changes
sbernauer and others added 3 commits March 21, 2024 10:36
@sbernauer @siegfriedweber
Update rego/hdfs.rego
f10c102 
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
@sbernauer
Add missing shortUser test
00bdb22
@sbernauer
fix test name
7baeecd
@siegfriedweber
Copy link
Member

siegfriedweber commented Mar 21, 2024

What about test/stack/11-rego-rules.yaml? Should this file be in sync with rego/hdfs.rego?

@sbernauer
Copy link
Member Author

sbernauer commented Mar 21, 2024

Should this file be in sync with rego/hdfs.rego?

Yes, at least the actual rules (the data section differs). See 03772f3

siegfriedweber
siegfriedweber previously approved these changes Mar 22, 2024
View reviewed changes
@sbernauer
Copy link
Member Author

sbernauer commented Mar 25, 2024

@siegfriedweber I tested the Tilt stack again and fixed various stuff, so the tests pass again

siegfriedweber
siegfriedweber approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test passed.

@sbernauer sbernauer added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit ec49972 Mar 26, 2024
@sbernauer sbernauer deleted the feat/prod-rego-rules branch March 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @siegfriedweber