Skip to content

[Merged by Bors] - Support specifying a namespace to watch#351

Closed
maltesander wants to merge 7 commits intomainfrom
feature/watch_single_namespace
Closed

[Merged by Bors] - Support specifying a namespace to watch#351
maltesander wants to merge 7 commits intomainfrom
feature/watch_single_namespace

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Feb 22, 2022 •
edited by razvan
Loading

Description

try

cargo run -- run --watch-namespace=test

fixes #341

TODO:

  • switch to tag

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team February 22, 2022 15:32
@maltesander maltesander self-assigned this Feb 22, 2022
razvan
razvan reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit redundant with the WATCH_NAMESPACE env var that is handled by the operator-rs. Do we need both ?

PS: I missed the change in operator-rs that added the additional command line arg. I feel we should have discussed this more beforehand.

@maltesander
Copy link
Member Author

maltesander commented Feb 22, 2022

This is a bit redundant with the WATCH_NAMESPACE env var that is handled by the operator-rs. Do we need both ?

PS: I missed the change in operator-rs that added the additional command line arg. I feel we should have discussed this more beforehand.

This only uses the --watch-namespace or WATCH_NAMESPACE env var from the operator-rs?

@maltesander maltesander marked this pull request as ready for review February 24, 2022 13:05
razvan
razvan approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maltesander
Copy link
Member Author

maltesander commented Feb 28, 2022

bors merge

bors bot pushed a commit that referenced this pull request Feb 28, 2022
@maltesander @razvan
Support specifying a namespace to watch (#351)
8ceb2c1 
## Description

try
```
cargo run -- run --watch-namespace=test
```

fixes #341

TODO:
- [ ] switch to tag



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Feb 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support specifying a namespace to watch [Merged by Bors] - Support specifying a namespace to watch Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the feature/watch_single_namespace branch February 28, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

Assignees

@maltesander maltesander

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support specifying a namespace to watch

2 participants

@maltesander @razvan