Skip to content

[Merged by Bors] - Migrate integration tests#409

Closed
maltesander wants to merge 8 commits intomainfrom
migrate_integration_tests
Closed

[Merged by Bors] - Migrate integration tests#409
maltesander wants to merge 8 commits intomainfrom
migrate_integration_tests

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Jun 3, 2022

Description

  • Moved tests to operator repo
  • Adapted to ADR018

Currently versions are provided as e.g. 3.1.0-stackable0 instead of the a fully qualified one like
3.1.0-scala2.13-opa_authorizer1.4.0-stackable0.5.0 which is not accepted by the product config semver crate.

Removed from integrations tests repo here: https://github.com/stackabletech/integration-tests/pull/248

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Jun 3, 2022
@maltesander maltesander requested review from a team and backstreetkiwi June 3, 2022 14:00
@maltesander maltesander marked this pull request as ready for review June 3, 2022 14:01
Copy link
Contributor

@backstreetkiwi backstreetkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 8, 2022
# Description

- Moved tests to operator repo
- Adapted to [ADR018](https://docs.stackable.tech/home/contributor/adr/ADR018-product_image_versioning.html)

Currently versions are provided as e.g. `3.1.0-stackable0` instead of the a fully qualified one like 
`3.1.0-scala2.13-opa_authorizer1.4.0-stackable0.5.0` which is not accepted by the product config semver crate.

Removed from integrations tests repo here: https://github.com/stackabletech/integration-tests/pull/248



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Nikolaus Winter <mail@nikolaus-winter.de>
@bors
Copy link
Contributor

bors bot commented Jun 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Migrate integration tests [Merged by Bors] - Migrate integration tests Jun 8, 2022
@bors bors bot closed this Jun 8, 2022
@bors bors bot deleted the migrate_integration_tests branch June 8, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants