Skip to content

[Merged by Bors] - feat: Set explicit resources on all containers #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: Set explicit resources on all containers #595

wants to merge 14 commits into from

Conversation

@razvan
Copy link
Member

@razvan razvan commented Jun 6, 2023 •
edited by lfrancke
Loading

Description

Part of: stackabletech/issues#394

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/42/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan mentioned this pull request Jun 6, 2023
Closed
@sbernauer sbernauer changed the title Smoke tests with resource quotas feat: Set explicit resources on all containers Jun 28, 2023
@maltesander maltesander self-assigned this Jun 29, 2023
@maltesander maltesander marked this pull request as ready for review June 29, 2023 12:50
@maltesander maltesander requested a review from a team June 29, 2023 14:08
@sbernauer sbernauer self-assigned this Jun 29, 2023
sbernauer
sbernauer requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor stuff

@maltesander @sbernauer
Apply suggestions from code review
8208e74 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander maltesander requested a review from sbernauer June 29, 2023 14:31
sbernauer
sbernauer approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM when tests pass

@maltesander
Copy link
Member

maltesander commented Jun 30, 2023

Trying azure:
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/43/

@maltesander
Copy link
Member

maltesander commented Jun 30, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 30, 2023
@razvan @maltesander
feat: Set explicit resources on all containers (#595)
60e5ce7 
# Description

Part of: stackabletech/issues#394

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/42/



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Set explicit resources on all containers [Merged by Bors] - feat: Set explicit resources on all containers Jun 30, 2023
@bors bors bot closed this Jun 30, 2023
@bors bors bot deleted the feat/resource-quotas branch June 30, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

@sbernauer sbernauer

Labels

release/23.7.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@razvan @maltesander @sbernauer @lfrancke