Skip to content

feat: Support graceful shutdown#635

Merged
sbernauer merged 6 commits intomainfrom
feat/graceful-shutdown
Nov 6, 2023
Merged

feat: Support graceful shutdown#635
sbernauer merged 6 commits intomainfrom
feat/graceful-shutdown

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 6, 2023

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [ ] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

@maltesander maltesander self-requested a review November 6, 2023 09:46
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some doc nitpicking and changelog. LGTM otherwise.

sbernauer and others added 3 commits November 6, 2023 10:55
Co-authored-by: Malte Sander <contact@maltesander.com>
@sbernauer
Copy link
Member Author

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passes!

@sbernauer sbernauer enabled auto-merge November 6, 2023 10:33
@sbernauer sbernauer added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 2117297 Nov 6, 2023
@sbernauer sbernauer deleted the feat/graceful-shutdown branch November 6, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants