Skip to content

Key listener selectors by listener UID#105

Merged
nightkr merged 3 commits intomainfrom
feature/require-listener-volume
Sep 11, 2023
Merged

Key listener selectors by listener UID#105
nightkr merged 3 commits intomainfrom
feature/require-listener-volume

Conversation

@nightkr
Copy link
Copy Markdown
Contributor

@nightkr nightkr commented Sep 7, 2023 •
edited
Loading

Description

Fixes #96

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@nightkr nightkr self-assigned this Sep 7, 2023
@nightkr nightkr requested a review from a team September 7, 2023 14:42
sbernauer
sbernauer approved these changes Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit b0d05d8 Sep 11, 2023
@bors bors bot deleted the feature/require-listener-volume branch September 11, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@nightkr nightkr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discourage users from adding Listener labels to Pods manually

2 participants

@nightkr @sbernauer