Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Jan 20, 2025

Description

Part of stackabletech/docker-images#975, stackabletech/docker-images#976

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr
Copy link
Contributor Author

nightkr commented Jan 20, 2025

@nightkr nightkr requested a review from a team January 20, 2025 11:00
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@nightkr nightkr requested a review from sbernauer January 20, 2025 12:38
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Checked the presence of the images, they do exist in Nexus but are still missing in Harbor.

@nightkr
Copy link
Contributor Author

nightkr commented Jan 20, 2025

I used the GH workflow in docker-images to mirror the images into Nexus. Do I need to do something different for Harbor?

@nightkr nightkr added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 9923494 Jan 20, 2025
17 checks passed
@nightkr nightkr deleted the chore/csi-sidecar-upgrade branch January 20, 2025 12:55
@sbernauer
Copy link
Member

Never mind, they images are in Harbor as well. Must have looked at the wrong place the first time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants