[Merged by Bors] - Apply default resources to deployed Daemonset and Deployment#85
Closed
soenkeliebau wants to merge 8 commits intomainfrom
Closed
[Merged by Bors] - Apply default resources to deployed Daemonset and Deployment#85soenkeliebau wants to merge 8 commits intomainfrom
soenkeliebau wants to merge 8 commits intomainfrom
Conversation
Adds documentation to explain why the listener operator needs to run as root in its containers. fixes #72
Split configuration into deployments and daemonsets.
# Conflicts: # CHANGELOG.md
nightkr
reviewed
Jun 28, 2023
deploy/helm/listener-operator/templates/controller-deployment.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Natalie <teo@nullable.se>
…default_resources # Conflicts: # deploy/helm/listener-operator/templates/controller-deployment.yaml # deploy/helm/listener-operator/templates/node-daemonset.yaml # deploy/helm/listener-operator/values.yaml
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
# Description This PR introduces functionality to apply default resource limits to Deployments and Daemonsets when installing the helm chart. It splits the configuration into two parameters for Deployment and DaemonSet and thus is marked as breaking because if someone defined resources in their values.yaml they would be applied to the Daemonset before this change, but would not be applied to it after this change. It will not work as is, but needs to be rebased once the changes made in stackabletech/operator-templating#262 have been merged and rolled out to this repository via templating.
|
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces functionality to apply default resource limits to Deployments and Daemonsets when installing the helm chart.
It splits the configuration into two parameters for Deployment and DaemonSet and thus is marked as breaking because if someone defined resources in their values.yaml they would be applied to the Daemonset before this change, but would not be applied to it after this change.
It will not work as is, but needs to be rebased once the changes made in stackabletech/operator-templating#262 have been merged and rolled out to this repository via templating.
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information