Skip to content

Add support for NiFi 1.15#125

Merged
fhennig merged 13 commits intomainfrom
support-15
Dec 3, 2021
Merged

Add support for NiFi 1.15#125
fhennig merged 13 commits intomainfrom
support-15

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 1, 2021

Description

  • Support for 1.15.0 was added and support for 1.13.2 removed.
  • The now required property nifi.sensitve.props.key can now be set via a secret.
  • The property is mounted as an enviroment variable into the container, it is added to the `nifi.properties by a script. For this to work, the docker image had to be modified, please se related pull request in that repository: Added update_config script to nifi (For NiFi 1.15) docker-images#27
  • A few new config settings were added and old ones removed.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rustfmt is complaining. Otherwise i would say we remove 1.13.2 completly?
Edit: Didnt see its still draft:)

@fhennig fhennig marked this pull request as ready for review December 3, 2021 11:28
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog link missing

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig fhennig merged commit 76728c7 into main Dec 3, 2021
@fhennig fhennig deleted the support-15 branch December 3, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants