[Merged by Bors] - Support specifying a namespace to watch#223
Closed
maltesander wants to merge 4 commits intomainfrom
Closed
[Merged by Bors] - Support specifying a namespace to watch#223maltesander wants to merge 4 commits intomainfrom
maltesander wants to merge 4 commits intomainfrom
Conversation
nightkr
reviewed
Feb 24, 2022
| @@ -0,0 +1,56 @@ | |||
|
|
|||
| === PRODUCT_CONFIG | |||
Contributor
There was a problem hiding this comment.
Isn't this the same bunch of fields that we specify in commandline_args.adoc?
Contributor
There was a problem hiding this comment.
I'd merge them into one file then. It's not really obvious that we have two places that need to be kept up to date atm, or how they relate to each other.
Member
Author
There was a problem hiding this comment.
I mean they come together via clap, the new opa side container e.g. does not use clap and would only require the env variable? I think in that case it makes sense to separate it?
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2022
## Description try ``` cargo run -- run --watch-namespace test ``` or ``` export WATCH_NAMESPACE=test cargo run -- run ``` fixes #214 Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
try
or
fixes #214
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information