Skip to content

[Merged by Bors] - Support specifying Service type#449

Closed
sbernauer wants to merge 5 commits intomainfrom
feat/service-type
Closed

[Merged by Bors] - Support specifying Service type#449
sbernauer wants to merge 5 commits intomainfrom
feat/service-type

Conversation

@sbernauer
Copy link
Member

Description

For stackabletech/issues#360

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer
Copy link
Member Author

@maltesander maltesander self-requested a review April 6, 2023 12:22
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passes!

@sbernauer sbernauer force-pushed the feat/service-type branch from be3b009 to 2e10718 Compare April 6, 2023 14:18
@sbernauer
Copy link
Member Author

bors bot pushed a commit that referenced this pull request Apr 11, 2023
@bors
Copy link
Contributor

bors bot commented Apr 11, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support specifying Service type [Merged by Bors] - Support specifying Service type Apr 11, 2023
@bors bors bot closed this Apr 11, 2023
@bors bors bot deleted the feat/service-type branch April 11, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants