Skip to content

[Merged by Bors] - Fix create-reporting-task to support multiple rolegroups#453

Closed
sbernauer wants to merge 3 commits intomainfrom
fix/multiple-rolegroups
Closed

[Merged by Bors] - Fix create-reporting-task to support multiple rolegroups#453
sbernauer wants to merge 3 commits intomainfrom
fix/multiple-rolegroups

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Apr 12, 2023

Description

Fixes bugs found in #452 such as

2023-04-10T15:46:25.281021Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="nificluster.nifi.stackable.tech" error=reconciler for object NifiCluster.v1alpha1.nifi.stackable.tech/test-nifi.
default failed error.sources=[failed to apply create ReportingTask job, Kubernetes reported error: ApiError: Job.batch "test-nifi-create-reporting-task-1-18-0" is invalid: spec.template: Invalid value: core.PodTemplateSpec{ObjectMe
ta:v1.ObjectMeta{Name:"test-nifi-create-reporting-task-1-18-0", GenerateName:"" ...  field is immutable: Invalid]

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer force-pushed the fix/multiple-rolegroups branch 2 times, most recently from 99caaf8 to 5107f00 Compare April 12, 2023 12:31
@sbernauer sbernauer changed the title Fix to support multiple rolegroups Fix create-reporting-task to support multiple rolegroups Apr 12, 2023
@sbernauer sbernauer self-assigned this Apr 12, 2023
@maltesander maltesander self-requested a review April 12, 2023 12:39
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@sbernauer
Copy link
Member Author

@sbernauer sbernauer force-pushed the fix/multiple-rolegroups branch from e8476af to 5c3931b Compare April 12, 2023 12:57
@maltesander
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Apr 12, 2023
# Description

Fixes bugs found in #452 such as
```
2023-04-10T15:46:25.281021Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="nificluster.nifi.stackable.tech" error=reconciler for object NifiCluster.v1alpha1.nifi.stackable.tech/test-nifi.
default failed error.sources=[failed to apply create ReportingTask job, Kubernetes reported error: ApiError: Job.batch "test-nifi-create-reporting-task-1-18-0" is invalid: spec.template: Invalid value: core.PodTemplateSpec{ObjectMe
ta:v1.ObjectMeta{Name:"test-nifi-create-reporting-task-1-18-0", GenerateName:"" ...  field is immutable: Invalid]
```



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix create-reporting-task to support multiple rolegroups [Merged by Bors] - Fix create-reporting-task to support multiple rolegroups Apr 12, 2023
@bors bors bot closed this Apr 12, 2023
@bors bors bot deleted the fix/multiple-rolegroups branch April 12, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants