Skip to content

[Merged by Bors] - Fix reporting task using ldap cn with spaces#466

Closed
maltesander wants to merge 5 commits intomainfrom
fix_reporting_task_using_ldap_cn_with_spaces
Closed

[Merged by Bors] - Fix reporting task using ldap cn with spaces#466
maltesander wants to merge 5 commits intomainfrom
fix_reporting_task_using_ldap_cn_with_spaces

Conversation

@maltesander
Copy link
Member

Description

fixes #465

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team May 2, 2023 16:57
@maltesander maltesander self-assigned this May 2, 2023
@maltesander maltesander marked this pull request as ready for review May 4, 2023 09:44
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request May 4, 2023
# Description

fixes #465



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 4, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Fix reporting task using ldap cn with spaces [Merged by Bors] - Fix reporting task using ldap cn with spaces May 4, 2023
@bors bors bot closed this May 4, 2023
@bors bors bot deleted the fix_reporting_task_using_ldap_cn_with_spaces branch May 4, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reporting tasks fails if LDAP CN contains whitespaces

2 participants