Skip to content

feat: Support PodDisruptionBudgets#509

Merged
sbernauer merged 7 commits intomainfrom
feat/support-pdb
Oct 6, 2023
Merged

feat: Support PodDisruptionBudgets#509
sbernauer merged 7 commits intomainfrom
feat/support-pdb

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 29, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

@sbernauer sbernauer mentioned this pull request Sep 29, 2023
Closed
@sbernauer sbernauer self-assigned this Sep 29, 2023
@maltesander maltesander self-requested a review October 5, 2023 12:52
@sbernauer sbernauer requested review from adwk67 and removed request for maltesander October 5, 2023 14:11
adwk67
adwk67 requested changes Oct 5, 2023
View reviewed changes
adwk67
adwk67 requested changes Oct 5, 2023
View reviewed changes
sbernauer and others added 3 commits October 6, 2023 08:00
@sbernauer @adwk67
Apply suggestions from code review
d7982de 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@sbernauer @adwk67
Update tests/templates/kuttl/smoke/30-assert.yaml
963a176 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@sbernauer
Merge branch 'main' into feat/support-pdb
485949a
@sbernauer sbernauer enabled auto-merge October 6, 2023 06:01
@sbernauer sbernauer requested a review from adwk67 October 6, 2023 06:01
adwk67
adwk67 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit cc05886 Oct 6, 2023
@sbernauer sbernauer deleted the feat/support-pdb branch October 6, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@sbernauer sbernauer

Labels

release/23.11.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @adwk67 @lfrancke