Skip to content

feat: Better CRD docs#537

Merged
fhennig merged 8 commits intomainfrom
feat/better-crd-docs
Dec 11, 2023
Merged

feat: Better CRD docs#537
fhennig merged 8 commits intomainfrom
feat/better-crd-docs

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 11, 2023

Description

Better CRD docs

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@fhennig fhennig enabled auto-merge December 11, 2023 12:59
@fhennig fhennig mentioned this pull request Dec 11, 2023
Closed
maltesander
maltesander requested changes Dec 11, 2023
View reviewed changes
fhennig and others added 3 commits December 11, 2023 14:39
@fhennig @maltesander
Update rust/crd/src/authentication.rs
21bb121 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@fhennig @maltesander
Update rust/crd/src/lib.rs
25b6df4 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
regenerate charts
ffb5d38
@fhennig fhennig requested a review from maltesander December 11, 2023 13:40
maltesander
maltesander approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhennig fhennig added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit de4dde8 Dec 11, 2023
@fhennig fhennig deleted the feat/better-crd-docs branch December 11, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fhennig @maltesander