feat: Make https secretclass configurable#622
Merged
Conversation
Member
Author
|
We talked about this in daily and took a decision shortcut as this is mostly a copy/paste from trino-operator. |
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #499
Alternate take on #529, but a little bit more simplistic.
I also renamed
clusterConfig.tls.httpSecretClasstoclusterConfig.tls.serverSecretClassto be consistent with other operators (like zk or trino).I skipped the whole "whether to request node certs" thing, as listener-op will replace it anyway.
CRD change
Definition of Done Checklist