Skip to content

feat: Make https secretclass configurable#622

Merged
sbernauer merged 7 commits intomainfrom
feat/tls-secret-class
May 27, 2024
Merged

feat: Make https secretclass configurable#622
sbernauer merged 7 commits intomainfrom
feat/tls-secret-class

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented May 23, 2024

Description

Fixes #499

Alternate take on #529, but a little bit more simplistic.
I also renamed clusterConfig.tls.httpSecretClass to clusterConfig.tls.serverSecretClass to be consistent with other operators (like zk or trino).

I skipped the whole "whether to request node certs" thing, as listener-op will replace it anyway.

CRD change

spec:
  clusterConfig:
    tls: # mandatory
      serverSecretClass: non-default-secret-class # mandatory, defaults to tls

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer requested review from a team and soenkeliebau May 23, 2024 06:54
@sbernauer sbernauer changed the title feat: Support specifying the SecretClass that is used to obtain TLS certificates feat: Make https secretclass configurable May 23, 2024
@sbernauer
Copy link
Member Author

We talked about this in daily and took a decision shortcut as this is mostly a copy/paste from trino-operator.

NickLarsenNZ
NickLarsenNZ previously approved these changes May 24, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

sbernauer and others added 2 commits May 24, 2024 13:42
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@sbernauer sbernauer requested a review from NickLarsenNZ May 24, 2024 11:42
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 22bcad4 May 27, 2024
@sbernauer sbernauer deleted the feat/tls-secret-class branch May 27, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support specifying a custom TLS secretclass

2 participants