Skip to content

feat: Support disabling and podOverrides on the create-reporting-task Job#690

Merged
sbernauer merged 11 commits intomainfrom
feat/reporting-job-pod-overrides
Oct 16, 2024
Merged

feat: Support disabling and podOverrides on the create-reporting-task Job#690
sbernauer merged 11 commits intomainfrom
feat/reporting-job-pod-overrides

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 11, 2024

Description

Closes #689

For CRD change look at deploy/helm/nifi-operator/crds/crds.yaml

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [x] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber
Copy link
Member

siegfriedweber commented Oct 14, 2024

Can the reporting task job also be seen as a role?

So, instead of

spec:
  clusterConfig:
    createReportingTaskJob:
      enabled: true
      podOverrides:
        ...
  nodes:
    roleGroups:
      default:
        podOverrides:
          ...

would it be better to create a top-level struct

spec:
  nodes:
    roleGroups:
      default:
        podOverrides:
          ...
  reportingTaskJob:
    enabled: true
    podOverrides:
      ...

?

Update: Proposal withdrawn after a discussion.

@sbernauer
Copy link
Member Author

Sure, we could also use spec.reportingTaskJob instead of spec.clusterConfig.reportingTaskJob.
However, this would be the first case we do that AFAIK, so far we always stuffed config that can only be configured on the whole stacklet below clusterConfig.

@sbernauer
Copy link
Member Author

sbernauer commented Oct 15, 2024

Vote here on the contents of the PR :) 👍 for accepting, 👎 for not accepting, with a comment with an alternative suggestion please

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things....

sbernauer and others added 4 commits October 16, 2024 08:27
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer sbernauer requested a review from maltesander October 16, 2024 06:29
@sbernauer sbernauer changed the title feat: Support podOverrides on the create-reporting-task Job feat: Support disabling and podOverrides on the create-reporting-task Job Oct 16, 2024
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit d94fae8 Oct 16, 2024
@sbernauer sbernauer deleted the feat/reporting-job-pod-overrides branch October 16, 2024 07:12
@lfrancke
Copy link
Member

Do we have/need docs for this and could you add a snippet for release notes?

@sbernauer
Copy link
Member Author

Docs where added in this PR

Support disabling the create-reporting-task Job as well as podOverrides on the Job

@lfrancke
Copy link
Member

Can you add a link to the docs please? (nightly is fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Support podOverriding the create-reporting Job

4 participants