feat: Support disabling and podOverrides on the create-reporting-task Job#690
feat: Support disabling and podOverrides on the create-reporting-task Job#690
Conversation
|
Can the reporting task job also be seen as a role? So, instead of spec:
clusterConfig:
createReportingTaskJob:
enabled: true
podOverrides:
...
nodes:
roleGroups:
default:
podOverrides:
...would it be better to create a top-level struct spec:
nodes:
roleGroups:
default:
podOverrides:
...
reportingTaskJob:
enabled: true
podOverrides:
...? Update: Proposal withdrawn after a discussion. |
|
Sure, we could also use |
|
Vote here on the contents of the PR :) 👍 for accepting, 👎 for not accepting, with a comment with an alternative suggestion please |
docs/modules/nifi/pages/usage_guide/configuration-environment-overrides.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
|
Do we have/need docs for this and could you add a snippet for release notes? |
|
Docs where added in this PR
|
|
Can you add a link to the docs please? (nightly is fine) |
Description
Closes #689
For CRD change look at
deploy/helm/nifi-operator/crds/crds.yamlDefinition of Done Checklist