Skip to content

fix: Fix typo in OIDC truststore strategy#698

Merged
sbernauer merged 2 commits intomainfrom
fix/oidc-truststore-strategy
Oct 28, 2024
Merged

fix: Fix typo in OIDC truststore strategy#698
sbernauer merged 2 commits intomainfrom
fix/oidc-truststore-strategy

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 28, 2024

Description

Fixup of #686

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer requested a review from labrenbe October 28, 2024 09:39
@sbernauer
Copy link
Member Author

Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for catching this!

@sbernauer
Copy link
Member Author

Test passed

@sbernauer sbernauer added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 8d4fc1b Oct 28, 2024
@sbernauer sbernauer deleted the fix/oidc-truststore-strategy branch October 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants