fix: Listen on loopback interface so that k8s port-forward works #870
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This required explicitly listening on eth0, otherwise only the loopback interface would be listening.
NickLarsenNZ
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
sbernauer
previously approved these changes
Nov 21, 2025
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Very nice, thanks!
Tested on IONOS, port-forward, NodePort and LoadBalancer all work
| "nifi.web.https.network.interface.default".to_string(), | ||
| "".to_string(), | ||
| ); | ||
| properties.insert( |
Member
There was a problem hiding this comment.
Can you please add a short comment on why we do it this way here?
Basically that the situation sucks, we rely on eht0 being present (WCGW? :D), mostly summarizing stuff you already written down + a link to #854
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #854
defaultsetting aloneI tested this with the getting_started guide (from scratch, with
make run-dev).