Skip to content

fix: Listen on loopback interface so that k8s port-forward works #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+20 −1
Open

fix: Listen on loopback interface so that k8s port-forward works #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19fbb00
fix: Listen on loopback interface so that k8s port-forward works
NickLarsenNZ Nov 20, 2025
1104ed6
chore: Update changelog
NickLarsenNZ Nov 20, 2025
33dd355
docs(getting_started): Remove ZooKeeper from example output
NickLarsenNZ Nov 20, 2025
da4d64d
fix: Use unnumbered loopback
NickLarsenNZ Nov 20, 2025
48c41f4
chore: Add comments explaining why we explicitly listen on interfaces
NickLarsenNZ Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed

- Also listen on the loopback interface so that k8s port-forwards work ([#870]).

[#870]: https://github.com/stackabletech/nifi-operator/pull/870

## [25.11.0] - 2025-11-07

## [25.11.0-rc1] - 2025-11-06
Expand Down
1 change: 0 additions & 1 deletion docs/modules/nifi/pages/getting_started/first_steps.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ The output should show all pods ready:
----
NAME READY AGE
simple-nifi-node-default 2/2 5m
simple-zk-server-default 3/3 7m
----

Congratulations! You successfully created your first NiFi cluster!
Expand Down
14 changes: 14 additions & 0 deletions rust/operator-binary/src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,20 @@ pub fn build_nifi_properties(
"nifi.web.https.network.interface.default".to_string(),
"".to_string(),
);
// Specifically listen on eth0 and lo interfaces.
// Listening on lo allows k8s port-forward to work.
// Once we listen on lo, we need to explicitly listen on eth0 so the server can be exposed (including health probes).
// NOTE: We assume "eth0" is always the external interface in containers launched in Kubernetes.
// It is possible that some container runtime will name it differently, but we haven't yet observed that.
properties.insert(
Copy link
Member

@sbernauer sbernauer Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a short comment on why we do it this way here?
Basically that the situation sucks, we rely on eht0 being present (WCGW? :D), mostly summarizing stuff you already written down + a link to #854

Copy link
Member Author

@NickLarsenNZ NickLarsenNZ Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!
See 48c41f4

"nifi.web.https.network.interface.eth0".to_string(),
"eth0".to_string(),
);
properties.insert(
"nifi.web.https.network.interface.lo".to_string(),
"lo".to_string(),
);
//#############################################
properties.insert(
"nifi.web.jetty.working.directory".to_string(),
"./work/jetty".to_string(),
Expand Down
Loading