feat(UserInfoFetcher): Add XFSC AAS backend#519
Merged
Conversation
Contributor
Author
NickLarsenNZ
previously approved these changes
Feb 13, 2024
Member
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Nice one. Left some comments, but pretty much non-blockers.
tests/templates/kuttl/aas-user-info/30-prepare-test-regorule.yaml
Outdated
Show resolved
Hide resolved
nightkr
reviewed
Feb 13, 2024
Contributor
nightkr
left a comment
There was a problem hiding this comment.
Haven't reviewed the tests
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
added 2 commits
February 14, 2024 10:24
Contributor
Author
|
@nightkr @NickLarsenNZ I still need to fix the test and run it again, but I think code wise everything should be fine. i didn't want to click "Resolve" on the open things, I wanted to leave it to you. Edit: new test run 🟢 |
nightkr
reviewed
Feb 14, 2024
nightkr
reviewed
Feb 14, 2024
Contributor
nightkr
left a comment
There was a problem hiding this comment.
Still not a complete review
sbernauer
reviewed
Feb 14, 2024
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
nightkr
reviewed
Feb 21, 2024
Contributor
nightkr
left a comment
There was a problem hiding this comment.
Largely LGTM. Did not run the tests myself. Ticked docs since I agree with not documenting this while it's experimental.
nightkr
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To integrade with gaia-x we need to fetch user claims from the AAS. this can be done with the UserInfoFetcher.
part of: https://github.com/stackabletech/marispace-x/issues/55
The integration test contains a small python container that mocks the API.
contains CRD changes, new backend: aas
Definition of Done Checklist