Skip to content

feat(UserInfoFetcher): Add XFSC AAS backend#519

Merged
fhennig merged 39 commits intomainfrom
feat/userinfofetcher-aas-backend
Feb 22, 2024
Merged

feat(UserInfoFetcher): Add XFSC AAS backend#519
fhennig merged 39 commits intomainfrom
feat/userinfofetcher-aas-backend

Conversation

@fhennig
Copy link
Copy Markdown
Contributor

@fhennig fhennig commented Feb 7, 2024

Description

To integrade with gaia-x we need to fetch user claims from the AAS. this can be done with the UserInfoFetcher.

part of: https://github.com/stackabletech/marispace-x/issues/55

The integration test contains a small python container that mocks the API.

contains CRD changes, new backend: aas

        clusterConfig:
          userInfo:
            backend:
              aas:
                hostname: aas.$NAMESPACE.svc.cluster.local
                port: 5000

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible: Add serviceaccounts to test containers
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@fhennig fhennig marked this pull request as ready for review February 12, 2024 16:23
@fhennig fhennig requested review from a team and removed request for a team February 12, 2024 16:25
@fhennig
Copy link
Copy Markdown
Contributor Author

fhennig commented Feb 13, 2024

@fhennig fhennig requested review from a team and nightkr February 13, 2024 12:43
NickLarsenNZ
NickLarsenNZ previously approved these changes Feb 13, 2024
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Left some comments, but pretty much non-blockers.

Copy link
Copy Markdown
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the tests

Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig
Copy link
Copy Markdown
Contributor Author

fhennig commented Feb 14, 2024

@nightkr @NickLarsenNZ I still need to fix the test and run it again, but I think code wise everything should be fine. i didn't want to click "Resolve" on the open things, I wanted to leave it to you.

Edit: new test run 🟢

Copy link
Copy Markdown
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a complete review

fhennig and others added 5 commits February 15, 2024 09:57
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
@fhennig fhennig requested review from nightkr and sbernauer February 19, 2024 10:51
Copy link
Copy Markdown
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM. Did not run the tests myself. Ticked docs since I agree with not documenting this while it's experimental.

@fhennig fhennig added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit fde6c54 Feb 22, 2024
@fhennig fhennig deleted the feat/userinfofetcher-aas-backend branch February 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants