-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat!: Add dedicated -metrics service #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Malte Sander <contact@maltesander.com>
|
Not merging now, waiting for the SDP 25.7 release team to update the changelog in main |
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Malte Sander <contact@maltesander.com>
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
All tests passed locally: |
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Release notesAdded
Changed
|
* feat!: Add dedicated -metrics service * changelog * improve doc comment * linter * linter * Add container port * fix port problem * fix tests und role service name * fix linter * Update rust/operator-binary/src/controller.rs Co-authored-by: Malte Sander <contact@maltesander.com> * changelog * changelog * changelog * Update CHANGELOG.md Co-authored-by: Malte Sander <contact@maltesander.com> * fix tests * ruff ruff --------- Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Malte Sander <contact@maltesander.com>
Description
Part of stackabletech/issues#692
The metrics Service was missed, as we skipped the listener rollout to OPA.
Also add a test that actually scrapes Prometheus metrics.
See changelog for detailed changes.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker