Skip to content

fix: Fix insecure file permissions #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

fix: Fix insecure file permissions #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3817a34
fix: Fix insecure file permissions
siegfriedweber Oct 17, 2025
f0d44aa
test: Fix a unit test assertion
siegfriedweber Oct 20, 2025
244bd3d
chore: Use new octal number format in YAML
siegfriedweber Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ All notable changes to this project will be documented in this file.
- Add Prometheus labels and annotations to role-group services ([#26]).
- Helm: Allow Pod `priorityClassName` to be configured ([#34]).
- Support log configuration and log aggregation ([#40]).
- Ensure that the permissions of the configuration files are correct ([#47]).

[#10]: https://github.com/stackabletech/opensearch-operator/pull/10
[#17]: https://github.com/stackabletech/opensearch-operator/pull/17
Expand All @@ -34,3 +35,4 @@ All notable changes to this project will be documented in this file.
[#34]: https://github.com/stackabletech/opensearch-operator/pull/34
[#38]: https://github.com/stackabletech/opensearch-operator/pull/38
[#40]: https://github.com/stackabletech/opensearch-operator/pull/40
[#47]: https://github.com/stackabletech/opensearch-operator/pull/47
1 change: 1 addition & 0 deletions docs/modules/opensearch/examples/getting_started/opensearch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ spec:
- name: security-config
secret:
secretName: opensearch-security-config
defaultMode: 0o660
- name: tls
ephemeral:
volumeClaimTemplate:
Expand Down
4 changes: 4 additions & 0 deletions rust/operator-binary/src/controller/build/role_group_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ impl<'a> RoleGroupBuilder<'a> {
Volume {
name: CONFIG_VOLUME_NAME.to_string(),
config_map: Some(ConfigMapVolumeSource {
default_mode: Some(0o660),
name: self.resource_names.role_group_config_map().to_string(),
..Default::default()
}),
Expand All @@ -268,6 +269,7 @@ impl<'a> RoleGroupBuilder<'a> {
Volume {
name: LOG_CONFIG_VOLUME_NAME.to_string(),
config_map: Some(ConfigMapVolumeSource {
default_mode: Some(0o660),
name: log_config_volume_config_map.to_string(),
..Default::default()
}),
Expand Down Expand Up @@ -1125,12 +1127,14 @@ mod tests {
"volumes": [
{
"configMap": {
"defaultMode": 0o660,
"name": "my-opensearch-cluster-nodes-default"
},
"name": "config"
},
{
"configMap": {
"defaultMode": 0o660,
"name": "my-opensearch-cluster-nodes-default"
},
"name": "log-config"
Expand Down
1 change: 1 addition & 0 deletions tests/templates/kuttl/external-access/opensearch.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ spec:
- name: security-config
secret:
secretName: opensearch-security-config
defaultMode: 0o660
- name: tls
ephemeral:
volumeClaimTemplate:
Expand Down
1 change: 1 addition & 0 deletions tests/templates/kuttl/ldap/21-install-opensearch.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ spec:
- name: security-config
secret:
secretName: opensearch-security-config
defaultMode: 0o660
- name: tls
ephemeral:
volumeClaimTemplate:
Expand Down
1 change: 1 addition & 0 deletions tests/templates/kuttl/metrics/20-install-opensearch.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ spec:
- name: security-config
secret:
secretName: opensearch-security-config
defaultMode: 0o660
- name: tls
ephemeral:
volumeClaimTemplate:
Expand Down
12 changes: 6 additions & 6 deletions tests/templates/kuttl/smoke/10-assert.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,19 +246,19 @@ spec:
terminationGracePeriodSeconds: 120
volumes:
- configMap:
defaultMode: 420
defaultMode: 0o660
name: opensearch-nodes-cluster-manager
name: config
- configMap:
defaultMode: 420
defaultMode: 0o660
name: opensearch-nodes-cluster-manager
name: log-config
- emptyDir:
sizeLimit: 30Mi
name: log
- name: security-config
secret:
defaultMode: 420
defaultMode: 0o660
secretName: opensearch-security-config
- ephemeral:
volumeClaimTemplate:
Expand Down Expand Up @@ -558,19 +558,19 @@ spec:
terminationGracePeriodSeconds: 120
volumes:
- configMap:
defaultMode: 420
defaultMode: 0o660
name: opensearch-nodes-data
name: config
- configMap:
defaultMode: 420
defaultMode: 0o660
name: opensearch-nodes-data
name: log-config
- emptyDir:
sizeLimit: 30Mi
name: log
- name: security-config
secret:
defaultMode: 420
defaultMode: 0o660
secretName: opensearch-security-config
- ephemeral:
volumeClaimTemplate:
Expand Down
1 change: 1 addition & 0 deletions tests/templates/kuttl/smoke/10-install-opensearch.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ spec:
- name: security-config
secret:
secretName: opensearch-security-config
defaultMode: 0o660
- name: tls
ephemeral:
volumeClaimTemplate:
Expand Down
Loading