-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat(stackable-webhook)!: Add support for mutating webhooks #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
Also a few things for me to check into which shouldn't block you.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Techassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for now, because there are a whole bunch of notes I have on this. These are best discussed verbally instead of writing back and forth.
Description
Part of stackabletech/commons-operator#111
Used by stackabletech/commons-operator#387
BREAKING: Refactor the entire
WebhookServermechanism, so multiple webhooks can run in parallel.Put individual webhooks (currently
ConversionWebhookandMutatingWebhook) behind theWebhooktrait.Definition of Done Checklist
Author
Reviewer
Acceptance