Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 18, 2025

Description

Part of stackabletech/commons-operator#111
Used by stackabletech/commons-operator#387

BREAKING: Refactor the entire WebhookServer mechanism, so multiple webhooks can run in parallel.
Put individual webhooks (currently ConversionWebhook and MutatingWebhook) behind the Webhook trait.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Also a few things for me to check into which shouldn't block you.

@sbernauer sbernauer marked this pull request as ready for review November 20, 2025 11:53
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
sbernauer and others added 2 commits November 20, 2025 13:39
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer moved this to Development: In Review in Stackable Engineering Nov 21, 2025
@sbernauer sbernauer self-assigned this Nov 21, 2025
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for now, because there are a whole bunch of notes I have on this. These are best discussed verbally instead of writing back and forth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

4 participants