Conversation
This change is based on stackabletech/decisions#84
NickLarsenNZ
previously approved these changes
Apr 22, 2026
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
I assume this breaks things until the operator Helm templates are corrected (in the same PR that this generates?)
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
Author
|
Good catch, I will update this PR. |
NickLarsenNZ
approved these changes
Apr 23, 2026
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
LGTM
There could be an operator that bypasses the helper and still refers to the image, so we will need to be careful before merging the generated PRs
Techassi
deleted the
chore/template-adjust-registry-specific-values-file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is based on https://github.com/stackabletech/decisions/issues/84.