Skip to content

fix: FFI/cgo string passing#133

Merged
Techassi merged 9 commits into
mainfrom
fix/ffi-cgo
Nov 6, 2023
Merged

fix: FFI/cgo string passing#133
Techassi merged 9 commits into
mainfrom
fix/ffi-cgo

Conversation

@Techassi
Copy link
Copy Markdown
Member

Fixes #131, implementation details are here.

@Techassi
Copy link
Copy Markdown
Member Author

As suspected, this needs further work to make MacOS builds compile again.

@Techassi
Copy link
Copy Markdown
Member Author

Compiles again!

Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM otherwise

Comment thread rust/helm-sys/src/lib.rs
@Techassi Techassi requested a review from sbernauer November 3, 2023 12:21
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Techassi Techassi added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 764757b Nov 6, 2023
@Techassi Techassi deleted the fix/ffi-cgo branch November 6, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation of 3rd party helm charts fails sporadically

2 participants