Skip to content

Fix duplicate content-type headers being sent for assets#137

Merged
nightkr merged 1 commit into
mainfrom
fix/assets-content-type-/actually-fix-it
Nov 3, 2023
Merged

Fix duplicate content-type headers being sent for assets#137
nightkr merged 1 commit into
mainfrom
fix/assets-content-type-/actually-fix-it

Conversation

@nightkr
Copy link
Copy Markdown
Contributor

@nightkr nightkr commented Nov 3, 2023

Description

Obsoletes #136, see #136 (comment)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much syntactic sugar from axum here :D

@nightkr nightkr added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 0211d0a Nov 3, 2023
@nightkr nightkr deleted the fix/assets-content-type-/actually-fix-it branch November 3, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants