fix: Semver version pre field doesn't contain dash#156
Merged
Conversation
This fixes the helm repo selection based on the parsed version. The old code had several short-comings: - The `pre` field doesn't include the dash used to separate version from pre. The matching however included this dash, resulting in wrong repo selection. - Versions where `pre` starts with `pr` didn't probably select the Helm test repo.
siegfriedweber
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the helm repo selection based on the parsed version. The old code had several short-comings:
prefield doesn't include the dash used to separate version from pre. The matching however included this dash, resulting in wrong repo selection.prestarts withprdidn't probably select the Helm test repo.