Skip to content

[Merged by Bors] - Extract the display logic from the listener table, make it sortable#25

Closed
nightkr wants to merge 9 commits into
mainfrom
feature/listener-datatable
Closed

[Merged by Bors] - Extract the display logic from the listener table, make it sortable#25
nightkr wants to merge 9 commits into
mainfrom
feature/listener-datatable

Conversation

@nightkr

@nightkr nightkr commented May 17, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes #3

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr marked this pull request as ready for review May 17, 2023 16:43
@nightkr nightkr requested a review from Techassi May 17, 2023 16:43
Comment thread web/src/components/datatable.tsx Outdated
Comment thread web/src/components/datatable.tsx Outdated
Comment thread web/src/components/datatable.tsx Outdated
Comment thread web/src/components/datatable.tsx Outdated
Comment thread web/src/components/datatable.tsx Outdated
Comment thread web/src/components/datatable.tsx Outdated
Comment thread web/src/components/datatable.tsx Outdated
Comment thread web/src/components/datatable.tsx
Comment thread web/src/components/datatable.tsx
Comment thread web/src/components/listeners.tsx Outdated

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. Other than that lgtm.

Comment thread web/src/components/datatable.tsx
Comment thread web/src/components/datatable.tsx Outdated
nightkr and others added 2 commits May 19, 2023 10:27
@nightkr nightkr requested a review from Techassi May 19, 2023 08:31
@nightkr

nightkr commented May 19, 2023

Copy link
Copy Markdown
Contributor Author

bors r+

bors Bot pushed a commit that referenced this pull request May 19, 2023
@bors

bors Bot commented May 19, 2023

Copy link
Copy Markdown

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors Bot changed the title Extract the display logic from the listener table, make it sortable [Merged by Bors] - Extract the display logic from the listener table, make it sortable May 19, 2023
@bors bors Bot closed this May 19, 2023
@bors bors Bot deleted the feature/listener-datatable branch May 19, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create data table component

2 participants