Rename crates to cockpit#58
Merged
Merged
Conversation
Techassi
requested changes
Jul 25, 2023
Techassi
left a comment
Member
There was a problem hiding this comment.
Mostly minor stuff, otherwise lgtm. Nice job!
Techassi
approved these changes
Jul 25, 2023
Techassi
left a comment
Member
There was a problem hiding this comment.
Approved.
A little off-topic: We might want to add yarn install to the web build script as it otherwise fails to run various actions, like rustdoc or clippy. We can also add the conditional to only run yarn install if node_modules is not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29.
Also organizes the Rust crates into
rust/(to align with the other Stackable repos), moves libcockpit out of the root folder (which should help avoid silly stuff like includingnode_modules/in its build closure), and moves the Helm wrapper into its own crate.Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information