Skip to content

Rename crates to cockpit#58

Merged
nightkr merged 16 commits into
mainfrom
chore/reorganize-and-rename
Jul 25, 2023
Merged

Rename crates to cockpit#58
nightkr merged 16 commits into
mainfrom
chore/reorganize-and-rename

Conversation

@nightkr

@nightkr nightkr commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes #29.

Also organizes the Rust crates into rust/ (to align with the other Stackable repos), moves libcockpit out of the root folder (which should help avoid silly stuff like including node_modules/ in its build closure), and moves the Helm wrapper into its own crate.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from Techassi July 24, 2023 14:51

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor stuff, otherwise lgtm. Nice job!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread default.nix
Comment thread rust/helm-sys/Cargo.toml Outdated
@nightkr nightkr requested a review from Techassi July 25, 2023 12:01

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

A little off-topic: We might want to add yarn install to the web build script as it otherwise fails to run various actions, like rustdoc or clippy. We can also add the conditional to only run yarn install if node_modules is not present.

@nightkr nightkr enabled auto-merge July 25, 2023 13:14
@nightkr nightkr added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit 3c1b65a Jul 25, 2023
@nightkr nightkr deleted the chore/reorganize-and-rename branch July 25, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename projects to cockpit

2 participants