Skip to content

feat: Implement endpoint listing#91

Merged
sbernauer merged 24 commits into
mainfrom
feat/endpoints
Aug 16, 2023
Merged

feat: Implement endpoint listing#91
sbernauer merged 24 commits into
mainfrom
feat/endpoints

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Aug 10, 2023 •
edited
Loading

Description

Currently only supports NodePort and LoadBalancer, which should cover all our currently supported deploy modes.
Old stackablectl only supports NodePort (as we only supported that at the time of implementation)

➜  stackable-cockpit git:(feat/endpoints) ✗ cargo r -p stackablectl -- stacklet ls
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/stackablectl stacklet ls`
┌────────────┬───────────────────────────────────────┬───────────┬─────────────────────────────────────────────────┬────────────────────────────────────────────┐
│ PRODUCT    ┆ NAME                                  ┆ NAMESPACE ┆ ENDPOINTS                                       ┆ CONDITIONS                                 │
╞════════════╪═══════════════════════════════════════╪═══════════╪═════════════════════════════════════════════════╪════════════════════════════════════════════╡
│ hive       ┆ hive                                  ┆ default   ┆                                                 ┆ Available, Reconciling, Running            │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ hive       ┆ hive-iceberg                          ┆ default   ┆ hive                85.215.160.93:32518         ┆ Available, Reconciling, Running            │
│            ┆                                       ┆           ┆ metrics             85.215.160.93:32640         ┆                                            │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ opa        ┆ opa                                   ┆ default   ┆                                                 ┆ Available, Reconciling, Running            │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ superset   ┆ superset                              ┆ default   ┆ external-superset   http://85.215.211.71:8088   ┆ Available, Reconciling, Running            │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ trino      ┆ trino                                 ┆ default   ┆ coordinator-metrics 85.215.170.131:8081         ┆ Unavailable: See [1], Reconciling, Running │
│            ┆                                       ┆           ┆ coordinator-https   https://85.215.170.131:8443 ┆                                            │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ grafana    ┆ prometheus-grafana                    ┆ default   ┆ http-web            http://85.215.194.208:31035 ┆                                            │
├╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ prometheus ┆ prometheus-kube-prometheus-prometheus ┆ default   ┆ http-web            http://85.215.194.208:30935 ┆                                            │
└────────────┴───────────────────────────────────────┴───────────┴─────────────────────────────────────────────────┴────────────────────────────────────────────┘

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

sbernauer
sbernauer commented Aug 10, 2023
View reviewed changes
Comment thread rust/stackable-cockpit/src/platform/stacklet/minio.rs Outdated
Comment thread rust/stackable-cockpit/src/platform/stacklet/minio.rs Outdated
Comment thread rust/stackable-cockpit/src/platform/stacklet/opensearch.rs Outdated
@sbernauer sbernauer requested a review from Techassi August 10, 2023 14:23
@Techassi
Copy link
Copy Markdown
Member

Techassi commented Aug 11, 2023

Some proposed changes: feat/endpoints...feat/endpoints-techassi

Techassi
Techassi reviewed Aug 11, 2023
View reviewed changes
Comment thread web/src/pages/stacklets/list.tsx Outdated
@sbernauer sbernauer requested a review from Techassi August 11, 2023 12:44
@sbernauer sbernauer self-assigned this Aug 14, 2023
Techassi
Techassi requested changes Aug 14, 2023
View reviewed changes
Comment thread rust/stackable-cockpit/src/platform/stacklet/grafana.rs
Comment thread rust/stackable-cockpit/src/platform/stacklet/minio.rs
Comment thread rust/stackable-cockpit/src/platform/stacklet/prometheus.rs
Comment thread rust/stackable-cockpit/src/utils/k8s/client.rs Outdated
Comment thread web/src/localization/locale/sv.ftl
@sbernauer sbernauer requested a review from Techassi August 14, 2023 08:43
Techassi
Techassi previously approved these changes Aug 16, 2023
View reviewed changes
@sbernauer
Copy link
Copy Markdown
Member Author

sbernauer commented Aug 16, 2023

@Techassi sorry, had to merge main into this branch

@sbernauer sbernauer enabled auto-merge August 16, 2023 11:26
@sbernauer sbernauer added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit ea25f42 Aug 16, 2023
@sbernauer sbernauer deleted the feat/endpoints branch August 16, 2023 12:04
sbernauer added a commit to sbernauer/stackable-cockpit that referenced this pull request Aug 17, 2023
@sbernauer @Techassi
feat: Implement endpoint listing (stackabletech#91)
3cd8db3 
* refactor: Refactor kube.rs and move to utils

* feat: Implement KubeClient::get_cluster_info

* WIP. Filter to worker nodes is still missing

* Improve CLusterInfo

* Only count untainted nodes. Improve errror handling

* cleanup

* cleanup

* fix: docs

* WIP!!!

* refactor

* Add very, very basic WebUI support

* prettier

* Make text white

* prettier

* Slight restructure

* Fix KubeClient::.get_endpoints signature

* web: Fix stackles list

* fixup

* Rework MinIO integration

* Implement opensearch

* rename get_endpoint -> get_endpoints

* Fix broken links in UI

---------

Co-authored-by: Techassi <git@techassi.dev>
sbernauer added a commit that referenced this pull request Aug 18, 2023
@sbernauer
fix: Add missing permission in clusterrole
60203c7 
Leftover of #91
@sbernauer sbernauer mentioned this pull request Aug 18, 2023
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Aug 18, 2023
@sbernauer
fix: Add missing permission in clusterrole (#100)
80dce04 
Leftover of #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @Techassi