Skip to content

Add action to build stackablectl release binaries (no Windows)#96

Merged
sbernauer merged 17 commits into
stackabletech:mainfrom
sbernauer:main
Aug 18, 2023
Merged

Add action to build stackablectl release binaries (no Windows)#96
sbernauer merged 17 commits into
stackabletech:mainfrom
sbernauer:main

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer requested a review from Techassi August 18, 2023 09:01
Copy link
Copy Markdown
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this pipeline is fine as is. However, I will invest some time to streamline our worflows as there are many (small) adjustments we can do to improve our CI pipelines.

Comment thread .github/workflows/build.yml Outdated
Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
sbernauer and others added 3 commits August 18, 2023 11:34
@sbernauer sbernauer requested a review from Techassi August 18, 2023 09:39
@sbernauer sbernauer added this pull request to the merge queue Aug 18, 2023
Merged via the queue into stackabletech:main with commit 695d860 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants