Skip to content

feat: Superset Listener integration #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 6, 2025
Merged

feat: Superset Listener integration #625

merged 21 commits into from
May 6, 2025

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Apr 24, 2025 •
edited
Loading

Description

fixes: #592

Openshift 🟢

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@adwk67 adwk67 marked this pull request as ready for review April 28, 2025 15:20
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Apr 29, 2025
@adwk67 adwk67 self-assigned this Apr 29, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 2, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review May 2, 2025 10:39
NickLarsenNZ
NickLarsenNZ requested changes May 2, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change on the docs, but you can decide which of the other suggestions you want to take.

adwk67 and others added 10 commits May 5, 2025 09:47
@adwk67 @NickLarsenNZ
Update rust/operator-binary/src/crd/mod.rs
df0773a 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update rust/operator-binary/src/superset_controller.rs
a967ae7 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update rust/operator-binary/src/superset_controller.rs
37743a9 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67
fixed typo/formatting
cf2b664
@adwk67
fixed inconsistency in docs
f9b3f5c
@adwk67
changelog entry marked as breaking
0de25d4
@adwk67 @NickLarsenNZ
Update rust/operator-binary/src/crd/mod.rs
7301589 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update rust/operator-binary/src/superset_controller.rs
7bce0dd 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67 @NickLarsenNZ
Update rust/operator-binary/src/superset_controller.rs
ed1a1c7 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67
use to_owned for showing intention
80a5fcf
@adwk67 adwk67 requested a review from NickLarsenNZ May 5, 2025 11:28
NickLarsenNZ

This comment was marked as outdated.

Sign in to view

@adwk67
Copy link
Member Author

adwk67 commented May 6, 2025 •
edited
Loading

Jenkins 🟢

NickLarsenNZ
NickLarsenNZ approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit b29105c May 6, 2025
17 checks passed
@adwk67 adwk67 deleted the feat/integrate-listener-operator branch May 6, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi left review comments

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@adwk67 adwk67

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate Superset Operator with Listener Operator

3 participants

@adwk67 @NickLarsenNZ @Techassi