Closed
Conversation
…operator into druid-connection
…operator into druid-connection
maltesander
approved these changes
Feb 1, 2022
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
LGTM.
I had the one comment for namespaces. This is not part of this PR so im happy to merge as is (and create an issue and (or) PR where we address this).
Contributor
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2022
## Description This PR refactors the init process and adds a new custom resource for druid connections. The Init resource is now called SupersetDB and also tracks a status. it is first `Provisioned`. If possible (secret also deployed) a kubernetes `Job` is started and the status of the CR becomes `Initializing`. The job is watched, and depending on whether it successfully completes or not, the SupersetDB also becomes `Ready` or `Failed` respectively. This change allows us to also depend on the DB being ready (or not). This is necessary for writing the druid connection information into the DB. A new CRD is introduced: `DruidConnection`. It holds information about the superset DB it should write to, and the Druid cluster that should be connected. A new controller watches the discovery config map as well as the superset DB resources. Once all the dependencies are there (and `Ready`) a job is started, and the status is updated, just like it is done for the `SupersetDB`. This is in line with the declarative philosophy of k8s; the spec reflects the desired state and the status tracks the actual underlying cluster. Also, with multiple controllers watching object states, control flow is delegated a bit to the API server. Before we were watching the job state manually, now we react to status changes which are given to us by the API server. The controllers only react to object changes. This PR also relies on the Druid Discovery PR stackabletech/druid-operator#102 What wasn't done: If the DruidConnection resource is deleted, the actual connection is not deleted. The issue doesn't say that this is necessary, and there is no obvious, documented way to delete data sources from the commandline, we'd have to go into the database and delete stuff there. On the controller side we can use a [finalizer](https://github.com/kube-rs/kube-rs/blob/d90ee9706923ceddf94c3d50928bc390543af2fc/examples/secret_syncer.rs#L92-L102). Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
stackable-bot
added a commit
that referenced
this pull request
Feb 10, 2022
…ackabletech/operator-templating repo. Original commit message: Adds missing --- start token to please yamllint (#71)
bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
Automatically created PR based on commit 5da434fdc7a60487b12badfdc8c5458dfb4b66da in stackabletech/operator-templating repo. Original commit message: Adds missing --- start token to please yamllint (#71)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the init process and adds a new custom resource for druid connections.
The Init resource is now called SupersetDB and also tracks a status. it is first
Provisioned. If possible (secret also deployed) a kubernetesJobis started and the status of the CR becomesInitializing. The job is watched, and depending on whether it successfully completes or not, the SupersetDB also becomesReadyorFailedrespectively.This change allows us to also depend on the DB being ready (or not). This is necessary for writing the druid connection information into the DB.
A new CRD is introduced:
DruidConnection. It holds information about the superset DB it should write to, and the Druid cluster that should be connected. A new controller watches the discovery config map as well as the superset DB resources. Once all the dependencies are there (andReady) a job is started, and the status is updated, just like it is done for theSupersetDB.This is in line with the declarative philosophy of k8s; the spec reflects the desired state and the status tracks the actual underlying cluster. Also, with multiple controllers watching object states, control flow is delegated a bit to the API server. Before we were watching the job state manually, now we react to status changes which are given to us by the API server. The controllers only react to object changes.
This PR also relies on the Druid Discovery PR stackabletech/druid-operator#102
What wasn't done: If the DruidConnection resource is deleted, the actual connection is not deleted. The issue doesn't say that this is necessary, and there is no obvious, documented way to delete data sources from the commandline, we'd have to go into the database and delete stuff there. On the controller side we can use a finalizer.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information