Skip to content

[Merged by Bors] - Updated to operator-rs 0.10.0, added scraping label#118

Closed
maltesander wants to merge 5 commits intomainfrom
dependecies_and_scraping
Closed

[Merged by Bors] - Updated to operator-rs 0.10.0, added scraping label#118
maltesander wants to merge 5 commits intomainfrom
dependecies_and_scraping

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Feb 9, 2022 •
edited
Loading

Description

fixes #103

  • updated to operator-rs 0.10.0
  • added scraping label

TODO:

  • Switch to regorule tag

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team February 9, 2022 12:03
@maltesander maltesander self-assigned this Feb 9, 2022
nightkr
nightkr reviewed Feb 9, 2022
View reviewed changes
maltesander and others added 3 commits February 9, 2022 13:19
@maltesander maltesander marked this pull request as ready for review February 9, 2022 14:57
razvan
razvan approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@maltesander
Copy link
Member Author

maltesander commented Feb 9, 2022

bors merge

bors bot pushed a commit that referenced this pull request Feb 9, 2022
@maltesander
Updated to operator-rs 0.10.0, added scraping label (#118)
b5b771e 
## Description

fixes #103

- updated to operator-rs 0.10.0
- added scraping label

TODO:
- [x] Switch to regorule tag



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 9, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Updated to operator-rs 0.10.0, added scraping label [Merged by Bors] - Updated to operator-rs 0.10.0, added scraping label Feb 9, 2022
@bors bors bot closed this Feb 9, 2022
@bors bors bot deleted the dependecies_and_scraping branch February 9, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

+1 more reviewer

@nightkr nightkr nightkr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@maltesander maltesander

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Prometheus scraping

3 participants

@maltesander @razvan @nightkr