[Merged by Bors] - Authorization overhaul#186
Closed
maltesander wants to merge 8 commits intomainfrom
Closed
Conversation
Contributor
|
I'll review this |
added 2 commits
April 12, 2022 14:10
Contributor
|
Alright, so the code looks good, I'll test now |
Contributor
|
The dependency on the secret operator is not documented |
Contributor
|
The documentation doesn't say how to get to the Web UI |
fhennig
approved these changes
Apr 13, 2022
Contributor
fhennig
left a comment
fhennig
left a comment
There was a problem hiding this comment.
I've created tickets for the documentation issues as well as the missing test
Member
Author
Thanks! |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
## Description - removed authorization module - switched to `OpaConfig` from operator-rs closes #167 Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Felix Hennig <felix.hennig@stackable.de>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpaConfigfrom operator-rscloses #167
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information