Skip to content

[Merged by Bors] - Add temporary attribute to support using ClusterIP instead of NodePort service type#272

Closed
sbernauer wants to merge 1 commit intomainfrom
disable-nodeport-svc
Closed

[Merged by Bors] - Add temporary attribute to support using ClusterIP instead of NodePort service type#272
sbernauer wants to merge 1 commit intomainfrom
disable-nodeport-svc

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 6, 2022 •
edited
Loading

Description

Fixes #269

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer marked this pull request as ready for review September 6, 2022 10:01
@sbernauer
Copy link
Member Author

sbernauer commented Sep 6, 2022

Started test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/20/console

@maltesander maltesander self-requested a review September 6, 2022 10:56
maltesander
maltesander approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests work!

@sbernauer
Copy link
Member Author

sbernauer commented Sep 6, 2022

Tests succeeded

@sbernauer
Copy link
Member Author

sbernauer commented Sep 6, 2022

bors r+

@nightkr
Copy link
Contributor

nightkr commented Sep 6, 2022

Are we OK with generating unusable discovery configs when this is used?

@sbernauer
Copy link
Member Author

sbernauer commented Sep 6, 2022

We don't create a XXX-nodeport discovery cm, only the discovery cm containing the Pod fqdn
For hive we only create the XXX-nodeport discovery cm when NodePort ist used (see stackabletech/hive-operator#237)

@nightkr
Copy link
Contributor

nightkr commented Sep 6, 2022

Ah!

@sbernauer
Copy link
Member Author

sbernauer commented Sep 6, 2022

bors r+

bors bot pushed a commit that referenced this pull request Sep 6, 2022
@sbernauer
Add temporary attribute to support using ClusterIP instead of NodePor…
88769b0 
…t service type (#272)

# Description

Fixes #269
@bors
Copy link
Contributor

bors bot commented Sep 6, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add temporary attribute to support using ClusterIP instead of NodePort service type [Merged by Bors] - Add temporary attribute to support using ClusterIP instead of NodePort service type Sep 6, 2022
@bors bors bot closed this Sep 6, 2022
@bors bors bot deleted the disable-nodeport-svc branch September 6, 2022 13:22
@soenkeliebau soenkeliebau mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add flag/enum to the CRD to switch between NodePorts and ClusterIps in services

3 participants

@sbernauer @nightkr @maltesander