[Merged by Bors] - Support specifying Service type#406
Closed
[Merged by Bors] - Support specifying Service type#406
Conversation
sbernauer
force-pushed
the
feat/service-type
branch
from
2a8b2df to
15998f7
Compare
sbernauer
force-pushed
the
feat/service-type
branch
from
15998f7 to
003ad61
Compare
maltesander
approved these changes
Apr 4, 2023
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
LGTM if we agreed on the listener_class names :)
Co-authored-by: Malte Sander <contact@maltesander.com>
Member
Author
|
We chatted about this in #product-listener and decided to stick with the current names |
Member
Author
Member
Author
|
Test failed, but I think it's normal flakiness |
Member
Author
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
# Description For stackabletech/issues#360 *Please add a description here. This will become the commit message of the merge request later.*
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For stackabletech/issues#360
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information