Skip to content

feat: Support PodDisruptionBudgets#481

Merged
sbernauer merged 10 commits intomainfrom
feat/support-pdb
Oct 6, 2023
Merged

feat: Support PodDisruptionBudgets#481
sbernauer merged 10 commits intomainfrom
feat/support-pdb

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 29, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added

@sbernauer sbernauer mentioned this pull request Sep 29, 2023
Closed
@sbernauer
Copy link
Member Author

sbernauer commented Sep 29, 2023

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/101/

@sbernauer sbernauer self-assigned this Sep 29, 2023
@sbernauer
Copy link
Member Author

sbernauer commented Sep 29, 2023

Retry https://ci.stackable.tech/job/trino-operator-it-custom/102/

@sbernauer sbernauer requested a review from maltesander October 5, 2023 13:42
@sbernauer sbernauer requested review from adwk67 and removed request for maltesander October 5, 2023 14:20
maltesander
maltesander requested changes Oct 5, 2023
View reviewed changes
sbernauer and others added 3 commits October 5, 2023 16:25
@sbernauer @maltesander
Update docs/modules/trino/pages/usage-guide/operations/pod-disruption…
6d31346 
…s.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer @maltesander
Apply suggestions from code review
e8be4e5 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer
Merge branch 'main' into feat/support-pdb
4a97317
@sbernauer sbernauer enabled auto-merge October 6, 2023 07:14
maltesander
maltesander approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 32f4aec Oct 6, 2023
@sbernauer sbernauer deleted the feat/support-pdb branch October 6, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

@adwk67 adwk67 Awaiting requested review from adwk67

Assignees

@sbernauer sbernauer

Labels

release/23.11.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @maltesander @lfrancke