Platform-agnostic wheel fixes#18
Merged
Merged
Conversation
rhsu-stackav
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how dependencies for different platforms are specified for conch. By default, a
pip install conch-triton-kernelswithout any extras specified will not install either torch or triton (instead defaulting to use whatever installation is already present in the environment). To install torch/triton for your platform, you can specify your accelerator type via extra, e.g.pip install "conch-triton-kernels[cuda]".Testing
Please select all that apply.
Test instructions
Nvidia
pip install -e ".[dev, cuda]"AMD
pip install -e ".[dev, rocm]" --extra-index-url https://download.pytorch.org/whl/rocm6.2.4Platforms
Please select all hardware platforms that this PR was tested on.
A10
1409 passed, 27018 skipped in 403.94s (0:06:43)H100
1583 passed, 26892 skipped in 301.48s (0:05:01)MI300X
1595 passed, 26880 skipped in 286.78s (0:04:46)