Added PostFeedLayout and PostCategoryLayout#15
Merged
TomasBankauskas merged 5 commits intomasterfrom Nov 30, 2021
Merged
Conversation
This was referenced Nov 17, 2021
JugglerX
reviewed
Nov 22, 2021
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| layout: PostCategoryLayout | |||
| title: React | |||
Contributor
There was a problem hiding this comment.
Not sure the title is being picked up correctly in the Studio which makes navigating the categories very confusing.
Also after creating a category using the red + button I land on the category page which is empty, and the side panel is empty... I realise this may be the expected behaviour of a category, but it just feels incomplete when using it as a user in the Studio.
Contributor
Author
There was a problem hiding this comment.
Hmmm, might be a bug, @TomasBankauskas as you work on the designs of the categories and post feeds can you add labelField: title to the PostCategoryLayout model.
smnh
force-pushed
the
post-feed-layout
branch
from
ccc2312 to
1d5ecc8
Compare
smnh
force-pushed
the
post-feed-layout
branch
from
1d5ecc8 to
79c5a64
Compare
smnh
force-pushed
the
post-feed-layout
branch
from
79c5a64 to
d509e42
Compare
TomasBankauskas
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
stackbit/stackbit-nextjs-starter#21
stackbit/stackbit-components#64