Conversation
- added sanity logic
- added datocms - updated sanity token param
- updated package versions
- updated sanity npx bin
- updated packages to public
- added executable header to executable files
- added lodash to deps
- added bin to stackbit-pull
- added bin to datocms and contentful
- fixed datocms options
- Updated Readme files
| "packages": [ | ||
| "packages/*" | ||
| ], | ||
| "version": "1.0.1-alpha.7" |
There was a problem hiding this comment.
@rodikh I think we should avoid releasing 1.x.x version.
Let's stick with minor for now.
The last one was 0.4.x. So we can use 0.5.x with "5" serving as non backward-compatible major.
Plus, I wish to avoid major "1" because we want to move to sourcebit anyway.
There was a problem hiding this comment.
also, set version to "independent"
| "packages": [ | ||
| "packages/*" | ||
| ], | ||
| "version": "1.0.1-alpha.7" |
There was a problem hiding this comment.
also, set version to "independent"
- independant versioning - downgraded core to 0.5
- downgraded all versions to 0.5
- downgraded all versions to 0.5
| * @param options {{dataset: string, preview: boolean, resolveLinks: boolean, allObjects: boolean, dataFormat: string, metadata: boolean, studioUrl: string}} | ||
| * @returns {PromiseLike<T>} | ||
| */ | ||
| function pull(projectId, ssgType, token, options) { |
There was a problem hiding this comment.
It seems that you have renamed the standard environment variable to dataset.
Will the container continue to work if parameters are different?
I think container's options have to be supported in order for it to work with the new stackbit-pull.
Currently container sends the following options.
const pullOptions = _.omitBy({
stackbitPullApiUrl: pullUrl,
apiKey: STACKBIT_API_SECRET,
dataFormat: 'object',
ver: 2,
preview: true,
metadata: true,
resolveLinks: false,
environment: this.repoPublishBranch || this.repoBranch
}, _.isNil);So either stackbit-pull needs additional layer that translates the parameters, or every specific cms pull (contentful-pull/sanity-pull) needs to support common option names such as preview/metadata/resolveLinks/environments
3 participants
Imported stackbit-pull code from API to remove API dependency
https://www.notion.so/stackbit/Factory-Remove-stackbit-pull-API-dependency-41cc87587b984c90b39a915692cdec8f