-
Notifications
You must be signed in to change notification settings - Fork 96
chore: add logs #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add logs #397
Conversation
commit: |
| <UProgress size="xs" class="absolute inset-x-0 top-0" /> | ||
| </div> | ||
|
|
||
| <div v-if="debugInfo && search" class="mb-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't put debugging info here!
what we should do in fact, is only injecting metadata in the backend response on each response we get from the search api.
| if (processedRepositories % 100 === 0) { | ||
| const elapsed = Date.now() - startTime; | ||
| console.log( | ||
| `Processed ${processedRepositories} repositories in ${elapsed}ms`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log are not useful since it's not easy to connect to the cloudflare dashboard. we just need metadata injected into the response.
what we might need to do is injecting try catches in different parts of the flow and seeing what errors we get.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing progress, after removing the ui code, let's merge this.
No description provided.