fix: dispose failed effect setup#119
Open
medz wants to merge 1 commit into
Open
Conversation
|
|
medz
added a commit
to medz/alien-signals-dart
that referenced
this pull request
May 15, 2026
Upstream PR: stackblitz/alien-signals#119 If upstream merges this fix, this commit can be treated as the synced port. If upstream closes or changes the approach, follow up against their final handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effect()nodes when initial setup throwseffectScope()nodes and children when setup throwsFixes #118
Validation
npm run checknpm test