Skip to content

Conversation

@JoseLion
Copy link
Member

@JoseLion JoseLion commented Sep 2, 2022

Resolves #62

@JoseLion JoseLion requested a review from byrpatrick September 2, 2022 22:58
@JoseLion JoseLion self-assigned this Sep 2, 2022
@JoseLion JoseLion force-pushed the docs/type-factory-usage branch 2 times, most recently from 9f14c58 to bb33c06 Compare September 2, 2022 23:28
Copy link
Member

@byrpatrick byrpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoseLion is looking good!!

I found a couple of typos. But I'm not approving it because I think the TypeFactories is not exported at the same level as expect.

@byrpatrick byrpatrick self-requested a review September 6, 2022 14:43
Copy link
Member

@byrpatrick byrpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice documentation! 🚀 💯

@JoseLion JoseLion force-pushed the docs/type-factory-usage branch from 3580cbb to 75a327e Compare September 6, 2022 14:54
@JoseLion JoseLion merged commit a2d8247 into main Sep 6, 2022
@JoseLion JoseLion deleted the docs/type-factory-usage branch September 6, 2022 14:58
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TypeFactory feature to the readme

3 participants