feat(object): Add .toHave[Keys|Values|Entries] methods #93
Conversation
| * @param keys the keys the object should have | ||
| * @returns the assertion instance | ||
| */ | ||
| public toHaveKeys(...keys: Array<keyof T>): this { |
There was a problem hiding this comment.
Should we consider naming this something like "toExactlyHaveKeys" or similar to denote that it is an exact comparation?. I'm not sure about this though. Let me know what you think. :)
There was a problem hiding this comment.
Yeah, I thought about something similar, but it'd be a bit repetitive because we already have .toContainKeys, which are not exact. Also, I'd prefer keeping the names small and straightforward so they are easier to use and remember 🙂
Let's keep it this way for now, and we can add an alias later if we think it's necessary.
ChristianSama
left a comment
ChristianSama
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 Just left a small question and a typo which should not be blockers
|
@all-contributors please add @ChristianSama for review |
|
I've put up a pull request to add @ChristianSama! 🎉 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #92