Added ability to set custom local_setttings.py.erb template path for hor...#13
Closed
namredips wants to merge 1 commit intostackforge:masterfrom
Closed
Added ability to set custom local_setttings.py.erb template path for hor...#13namredips wants to merge 1 commit intostackforge:masterfrom
namredips wants to merge 1 commit intostackforge:masterfrom
Conversation
…horizon. The default template in the horizon module only allows for conections from the local host. With no way of using a custom path, any local changes get overwritten
|
Thank you for contributing to stackforge/puppet-openstack! stackforge/puppet-openstack uses Gerrit for code review. Please visit http://wiki.openstack.org/GerritWorkflow and follow the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default template in the horizon module only allows for connections from the local host via ALLOWED_HOSTS. With no way of using a custom path, any local changes get overwritten every time the manifest is applied.
Simply exposed in openstack/horizon and openstack/controller what is available in horizon/init. By default, everything will continue to work as it did before. However now if desired, a manifest implementing openstack/controller can pass in a path to a custom local_settings file template.